linux-kernel - Re: [PATCH v6 2/5] rust: pci: provide access to PCI Vendor values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65072e90-a1cd-43bb-bc31-04b16947113f@nvidia.com>
Date: Tue, 26 Aug 2025 13:58:51 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 nouveau@...ts.freedesktop.org, linux-pci@...r.kernel.org,
 rust-for-linux@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Elle Rhumsaa <elle@...thered-steel.dev>
Subject: Re: [PATCH v6 2/5] rust: pci: provide access to PCI Vendor values

On 8/26/25 1:45 PM, Danilo Krummrich wrote:
> On 8/26/25 10:38 PM, John Hubbard wrote:
>> On 8/25/25 5:47 AM, Danilo Krummrich wrote:
>>> On Mon Aug 25, 2025 at 2:33 PM CEST, Alexandre Courbot wrote:
>> ...
> Sorry, that's on me being not precise. When I said private I meant private to
> the parent module.
> 
> The diff looks good, thanks!

Huge relief! :)

> 
> Please also make sure to add #[inline] where appropriate and rebase onto
> driver-core-next.

I have no idea "where appropriate" is, here. These are not hot paths, and
the existing pci.rs methods such as Device::vendor_id() are not inlined,
and so my initial approach is to just not inline any of this...

thanks,
-- 
John Hubbard