linux-kernel - Re: [PATCH 02/16] gpio: brcmstb: Use modern PM macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9aa8a07-4ed7-4a7f-a69a-ce496ede48cc@gmail.com>
Date: Tue, 26 Aug 2025 14:47:30 -0700
From: Doug Berger <opendmb@...il.com>
To: Jisheng Zhang <jszhang@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Michael Buesch <m@...s.ch>,
 Hoan Tran <hoan@...amperecomputing.com>, Andy Shevchenko <andy@...nel.org>,
 Daniel Palmer <daniel@...ngy.jp>, Romain Perier <romain.perier@...il.com>,
 Grygorii Strashko <grygorii.strashko@...com>,
 Santosh Shilimkar <ssantosh@...nel.org>, Kevin Hilman <khilman@...nel.org>,
 Robert Jarzmik <robert.jarzmik@...e.fr>,
 Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
 Srinivas Neeli <srinivas.neeli@....com>, Michal Simek <michal.simek@....com>
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, linux-gpio@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-omap@...r.kernel.org, linux@...tq-group.com
Subject: Re: [PATCH 02/16] gpio: brcmstb: Use modern PM macros

On 8/20/2025 8:40 AM, Jisheng Zhang wrote:
> Use the modern PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
> 
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>   drivers/gpio/gpio-brcmstb.c | 12 +++---------
>   1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index e29a9589b3cc..0ca3e0d8aa46 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -534,7 +534,6 @@ static void brcmstb_gpio_shutdown(struct platform_device *pdev)
>   	brcmstb_gpio_quiesce(&pdev->dev, false);
>   }
>   
> -#ifdef CONFIG_PM_SLEEP
>   static void brcmstb_gpio_bank_restore(struct brcmstb_gpio_priv *priv,
>   				      struct brcmstb_gpio_bank *bank)
>   {
> @@ -573,14 +572,9 @@ static int brcmstb_gpio_resume(struct device *dev)
>   	return 0;
>   }
>   
> -#else
> -#define brcmstb_gpio_suspend	NULL
> -#define brcmstb_gpio_resume	NULL
> -#endif /* CONFIG_PM_SLEEP */
> -
>   static const struct dev_pm_ops brcmstb_gpio_pm_ops = {
> -	.suspend_noirq	= brcmstb_gpio_suspend,
> -	.resume_noirq = brcmstb_gpio_resume,
> +	.suspend_noirq = pm_sleep_ptr(brcmstb_gpio_suspend),
> +	.resume_noirq = pm_sleep_ptr(brcmstb_gpio_resume),
>   };
>   
>   static int brcmstb_gpio_probe(struct platform_device *pdev)
> @@ -747,7 +741,7 @@ static struct platform_driver brcmstb_gpio_driver = {
>   	.driver = {
>   		.name = "brcmstb-gpio",
>   		.of_match_table = brcmstb_gpio_of_match,
> -		.pm = &brcmstb_gpio_pm_ops,
> +		.pm = pm_sleep_ptr(&brcmstb_gpio_pm_ops),
>   	},
>   	.probe = brcmstb_gpio_probe,
>   	.remove = brcmstb_gpio_remove,

Acked-by: Doug Berger <opendmb@...il.com>