[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <70B636E1-DA86-4CB0-A06D-4C0A99FD95BD@gmail.com>
Date: Tue, 26 Aug 2025 00:04:26 -0400
From: Jean-François Lessard <jefflessard3@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Andy Shevchenko <andy@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 6/6] auxdisplay: TM16xx: Add support for SPI-based controllers
Le 25 août 2025 11 h 19 min 21 s HAE, Andy Shevchenko <andriy.shevchenko@...el.com> a écrit :
>On Sun, Aug 24, 2025 at 11:32:32PM -0400, Jean-François Lessard wrote:
>> Add support for TM16xx-compatible auxiliary display controllers connected
>> via the SPI bus.
>>
>> The implementation includes:
>> - SPI driver registration and initialization
>> - Probe/remove logic for SPI devices
>> - Controller-specific handling and communication sequences
>> - Integration with the TM16xx core driver for common functionality
>>
>> This allows platforms using TM16xx or compatible controllers over SPI to be
>> managed by the TM16xx driver infrastructure.
>>
>> Signed-off-by: Jean-François Lessard <jefflessard3@...il.com>
>> ---
>
>> Notes:
>> include <linux/of.h> is required for of_match_ptr
>
>Yeah, please drop the latter and remove the former.
>
Well received.
>All other comments are the same as per I²C counterpart of the driver.
>
Acknowledged.
Powered by blists - more mailing lists