linux-kernel - Re: [PATCH v4] PCI: Introduce Cray ClusterStor E1000 NVMe slot LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5378177c-a2bf-4935-9156-0a4030903537@llnl.gov>
Date: Mon, 25 Aug 2025 17:15:51 -0700
From: Tony Hutter <hutter2@...l.gov>
To: corey@...yard.net
Cc: alok.a.tiwari@...cle.com, Bjorn Helgaas <helgaas@...nel.org>,
        Lukas Wunner <lukas@...ner.de>, mariusz.tkaczyk@...ux.intel.com,
        minyard@....org, linux-pci@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] PCI: Introduce Cray ClusterStor E1000 NVMe slot LED
 driver

> You shouldn't need to include ipmi_smi.h.  If you do, that's a bug on my
part.

Thanks, you're right that it builds without ipmi_smi.h.  I'll remove it in the next patch.

> I don't see anything that will prevent multiple messages from being sent
at one time.  What happens if two things send a message at the same time
here?

That shouldn't happen since the messages are serialized by craye1k->lock.  That lock is taken at the driver entry points: craye1k_get_attention_status() & craye1k_set_attention_status().