linux-kernel - Re: [PATCH v3 1/4] dt-bindings: reset: add Tegra114 car header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3303492.5fSG56mABF@senjougahara>
Date: Tue, 26 Aug 2025 17:29:52 +0900
From: Mikko Perttunen <mperttunen@...dia.com>
To: Svyatoslav Ryhel <clamor95@...il.com>,
 Thierry Reding <thierry.reding@...il.com>,
 Thierry Reding <treding@...dia.com>, Jonathan Hunter <jonathanh@...dia.com>,
 Prashant Gaikwad <pgaikwad@...dia.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: reset: add Tegra114 car header

On Tuesday, August 26, 2025 5:21 PM Krzysztof Kozlowski wrote:
> On 26/08/2025 08:11, Svyatoslav Ryhel wrote:
> > Binding values for special resets that are placed starting from
> > software-defined index 160 in line with other chips.
> > 
> > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > ---
> > 
> >  include/dt-bindings/reset/tegra114-car.h | 13 +++++++++++++
> 
> NAK
> 
> You got comments last time and you completely ignored them.
> 
> Best regards,
> Krzysztof

Thierry explained to you last time why this patch makes sense.

The existing binding is such that values below 160 map to clock IDs (in dt-
bindings/clock/tegra114-car.h). We cannot use those numbers for these "special 
resets" that have no corresponding clock, or we'd be changing existing 
binding. Hence this patch starts them at 160, above the clock IDs. The same 
already exists in the tegra124-car binding for TEGRA124_RST_DFLL_DVCO -- this 
just extends that to Tegra114.

Mikko