linux-kernel - Re: [PATCH 6/9] printk/nbcon: use panic_on_this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <504d5b94-e656-4c84-8da8-294459d3af2a@gmail.com>
Date: Tue, 26 Aug 2025 08:58:16 +0800
From: Jinchao Wang <wangjinchao600@...il.com>
To: John Ogness <john.ogness@...utronix.de>, pmladek@...e.com,
 akpm@...ux-foundation.org, Steven Rostedt <rostedt@...dmis.org>,
 Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: linux-kernel@...r.kernel.org, feng.tang@...ux.alibaba.com,
 joel.granados@...nel.org, namcao@...utronix.de, sravankumarlpu@...il.com
Subject: Re: [PATCH 6/9] printk/nbcon: use panic_on_this_cpu() helper

On 8/25/25 17:53, John Ogness wrote:
> On 2025-08-20, Jinchao Wang <wangjinchao600@...il.com> wrote:
>> nbcon_context_try_acquire() compared
>> panic_cpu directly with smp_processor_id().
>> This open-coded check is now provided by
>> panic_on_this_cpu().
>>
>> Switch to panic_on_this_cpu() to simplify
>> the code and improve readability.
>>
>> Signed-off-by: Jinchao Wang <wangjinchao600@...il.com>
>> ---
>>   kernel/printk/nbcon.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
>> index 646801813415..7490865e2f44 100644
>> --- a/kernel/printk/nbcon.c
>> +++ b/kernel/printk/nbcon.c
>> @@ -2,6 +2,7 @@
>>   // Copyright (C) 2022 Linutronix GmbH, John Ogness
>>   // Copyright (C) 2022 Intel, Thomas Gleixner
>>   
>> +#include "linux/panic.h"
>>   #include <linux/atomic.h>
>>   #include <linux/bug.h>
>>   #include <linux/console.h>
> 
> Please use angle brackets. Also, the includes are sorted
> alphabetically. So it should look like this:
> 
>   #include <linux/irqflags.h>
>   #include <linux/kthread.h>
>   #include <linux/minmax.h>
> +#include <linux/panic.h>
>   #include <linux/percpu.h>
>   #include <linux/preempt.h>
>   #include <linux/slab.h>
> 

Thanks for the feedback. This patch, v2, has been merged to the -mm 
branch already, but I will fix the include style in a separate cleanup 
patch.
-- 
Best regards,
Jinchao