linux-kernel - Re: netpoll: raspberrypi [4 5] driver locking woes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e32a52852025d522f44d9d6ccc88c716ff432f8f.camel@gmx.de>
Date: Tue, 26 Aug 2025 11:49:27 +0200
From: Mike Galbraith <efault@....de>
To: lkml <linux-kernel@...r.kernel.org>
Cc: Robert Hancock <robert.hancock@...ian.com>, Doug Berger
 <opendmb@...il.com>,  Florian Fainelli <florian.fainelli@...adcom.com>,
 Breno Leitao <leitao@...ian.org>
Subject: Re: netpoll:  raspberrypi [4 5]  driver locking woes

On Mon, 2025-08-25 at 07:53 +0200, Mike Galbraith wrote:
> 
> On the pi4, lockdep muttered about ring->lock in bcmgenet_xmit() and
> bcmgenet_tx_poll() - switching to irqsave/restore spinlock variants
> there silenced it.

I went ahead and submitted the pi4 patchlet.

The pi5 gripe fix is equally trivial, but submitting that is pointless
given there's something else amiss in fingered commit.  This is all of
the crash info that escapes the box w/wo gripes silenced.

[   51.688868] sysrq: Trigger a crash
[   51.688892] Kernel panic - not syncing: sysrq triggered crash
[   51.698066] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.17.0-rc2-v8-lockdep #533 PREEMPTLAZY
[   51.707234] Hardware name: Raspberry Pi 5 Model B Rev 1.0 (DT)
[   51.713085] Call trace:
[   51.715532]  show_stack+0x20/0x38 (C)
[   51.719206]  dump_stack_lvl+0x38/0xd0
[   51.722878]  dump_stack+0x18/0x28

That aspect is a punt and run atm (time.. and dash of laziness:).

	-Mike