linux-kernel - Re: [PATCH] gpio: timberdale: fix off-by-one in IRQ type boundary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175620259460.21991.7139337951107127710.b4-ty@linaro.org>
Date: Tue, 26 Aug 2025 12:03:17 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Junjie Cao <junjie.cao@...el.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: timberdale: fix off-by-one in IRQ type boundary check

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Mon, 25 Aug 2025 17:08:50 +0800, Junjie Cao wrote:
> timbgpio_irq_type() currently accepts offset == ngpio, violating
> gpiolib's [0..ngpio-1] contract. This can lead to undefined behavior
> when computing '1 << offset', and it is also inconsistent with users
> that iterate with for_each_set_bit(..., ngpio).
> 
> Tighten the upper bound to reject offset == ngpio. No functional change
> for in-range offsets.
> 
> [...]

Applied, thanks!

[1/1] gpio: timberdale: fix off-by-one in IRQ type boundary check
      https://git.kernel.org/brgl/linux/c/810e154d90f44127239957b06ee51a55553a5815

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>