linux-kernel - Re: [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b64c820d-084a-40d9-bb4e-82986b9e6482@linux.ibm.com>
Date: Tue, 26 Aug 2025 15:35:03 +0530
From: Shrikanth Hegde <sshegde@...ux.ibm.com>
To: K Prateek Nayak <kprateek.nayak@....com>,
        Peter Zijlstra <peterz@...radead.org>
Cc: Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
        Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
        thomas.weissschuh@...utronix.de, Li Chen <chenl311@...natelecom.cn>,
        Bibo Mao <maobibo@...ngson.cn>, Mete Durlu <meted@...ux.ibm.com>,
        Tobias Huschle <huschle@...ux.ibm.com>,
        Easwar Hariharan <easwar.hariharan@...ux.microsoft.com>,
        Guo Weikang <guoweikang.kernel@...il.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Brian Gerst <brgerst@...il.com>,
        Patryk Wlazlyn <patryk.wlazlyn@...ux.intel.com>,
        Swapnil Sapkal <swapnil.sapkal@....com>,
        "Yury Norov [NVIDIA]" <yury.norov@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Andrea Righi <arighi@...dia.com>,
        Yicong Yang <yangyicong@...ilicon.com>,
        Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr_level
 hack for tl->cpumask()



On 8/26/25 9:43 AM, K Prateek Nayak wrote:
> This version uses Peter's suggestion from [1] as if and incrementally
> adds cleanup on top to the arch/ bits. I've tested the x86 side but the
> PowerPC and the s390 bits are only build tested. Review and feedback is
> greatly appreciated.
> 
> [1] https://lore.kernel.org/lkml/20250825091910.GT3245006@noisy.programming.kicks-ass.net/
> 
> Patches are prepared on top of tip:master at commit 4628e5bbca91 ("Merge
> branch into tip/master: 'x86/tdx'")
> ---
> changelog v6..v7:
> 
> o Fix the s390 and ppc build errors (Intel test robot)
> 
> o Use Peter's diff as is and incrementally do the cleanup on top. The
>    PowerPC part was slightly more extensive due to the lack of
>    CONFIG_SCHED_MC in arch/powerpc/Kconfig.
> 
> v6: https://lore.kernel.org/lkml/20250825120244.11093-1-kprateek.nayak@amd.com/
> ---
> K Prateek Nayak (7):
>    powerpc/smp: Rename cpu_corgroup_* to cpu_corgrp_*
>    powerpc/smp: Export cpu_coregroup_mask()
>    powerpc/smp: Introduce CONFIG_SCHED_MC to guard MC scheduling bits
>    sched/topology: Unify tl_smt_mask() across core and all arch
>    sched/topology: Unify tl_cls_mask() across core and x86
>    sched/topology: Unify tl_mc_mask() across core and all arch
>    sched/topology: Unify tl_pkg_mask() across core and all arch
> 
> Peter Zijlstra (1):
>    sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask()
> 
Can the names be standardized to begin with tl_ ?

arch/powerpc/kernel/smp.c:			SDTL_INIT(smallcore_smt_mask, powerpc_smt_flags, SMT);
arch/powerpc/kernel/smp.c:			SDTL_INIT(shared_cache_mask, powerpc_shared_cache_flags, CACHE);
arch/s390/kernel/topology.c:	SDTL_INIT(cpu_book_mask, NULL, BOOK),
arch/s390/kernel/topology.c:	SDTL_INIT(cpu_drawer_mask, NULL, DRAWER),
kernel/sched/topology.c:	tl[i++] = SDTL_INIT(sd_numa_mask, NULL, NODE);
kernel/sched/topology.c:		tl[i] = SDTL_INIT(sd_numa_mask, cpu_numa_flags, NUMA);