linux-kernel - [PATCH v2] uio: uio_pdrv_genirq: Remove MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250826-uio-no-modalias-v2-1-495afa9e8a5b@iscas.ac.cn>
Date: Tue, 26 Aug 2025 18:34:40 +0800
From: Vivian Wang <wangruikang@...as.ac.cn>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Michal Simek <monstr@...str.eu>, Wolfram Sang <wsa@...nel.org>, 
 "Hans J. Koch" <hjk@...sjkoch.de>, Pavel Machek <pavel@....cz>
Cc: Vivian Wang <uwu@...m.page>, linux-kernel@...r.kernel.org, 
 Emily <hello@...ly.moe>, Vivian Wang <wangruikang@...as.ac.cn>
Subject: [PATCH v2] uio: uio_pdrv_genirq: Remove MODULE_DEVICE_TABLE

The struct of_device_id list here is filled in at load time since
commit 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices using
command line option").

However, this does not work with MODULE_DEVICE_TABLE, which generates an
alias at build time.  In this case, it generates the aliases "of:N*T*"
and "of:N*T*C*", which matches *any* OF device node, which is obviously
not intended. It confuses userspace into loading this module for any OF
device, and confuses anyone trying to resolve an OF modalias.

Remove this broken MODULE_DEVICE_TABLE.

Suggested-by: Emily <hello@...ly.moe>
Fixes: 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices using command line option")
Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>
---
Changes in v2:
- Point "Fixes:" to newer commit that added the placeholder entry
- Reworded commit message
- Link to v1: https://lore.kernel.org/r/20250824-uio-no-modalias-v1-1-aef6943d04ac@iscas.ac.cn
---
 drivers/uio/uio_pdrv_genirq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index 2ec7d25e826490999404382e6aa69e4af56f7fe8..633ab6b916719e783d0f82cb2f8decac35a37054 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -276,7 +276,6 @@ static struct of_device_id uio_of_genirq_match[] = {
 	{ /* This is filled with module_parm */ },
 	{ /* Sentinel */ },
 };
-MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
 module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
 MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
 #endif

---
base-commit: 062b3e4a1f880f104a8d4b90b767788786aa7b78
change-id: 20250824-uio-no-modalias-b9b4430308c8

Best regards,
-- 
Vivian "dramforever" Wang