linux-kernel - Re: [PATCH] bpf: Replace kvfree with kfree for kzalloc memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ff59e6c-b061-41ef-bdc8-8eaffe15aff9@iogearbox.net>
Date: Tue, 26 Aug 2025 13:43:52 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Feng Yang <yangfeng59949@....com>, ast@...nel.org,
 john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev,
 eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev,
 kpsingh@...nel.org, sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: Replace kvfree with kfree for kzalloc memory

On 8/26/25 9:39 AM, Feng Yang wrote:
> From: Feng Yang <yangfeng@...inos.cn>
> 
> Refer to https://lore.kernel.org/bpf/20250811123949.552885-1-rongqianfeng@vivo.com to replace the remaining part.

Please make this a proper commit message instead of just posting a lore link.
$subj should be [PATCH bpf-next].

> Signed-off-by: Feng Yang <yangfeng@...inos.cn>
> ---
>   kernel/bpf/verifier.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 5c9dd16b2c56..b9394f8fac0e 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -2021,7 +2021,7 @@ static void free_backedges(struct bpf_scc_visit *visit)
>   	for (backedge = visit->backedges; backedge; backedge = next) {
>   		free_verifier_state(&backedge->state, false);
>   		next = backedge->next;
> -		kvfree(backedge);
> +		kfree(backedge);
>   	}
>   	visit->backedges = NULL;
>   }
> @@ -19651,7 +19651,7 @@ static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
>   	err = maybe_enter_scc(env, new);
>   	if (err) {
>   		free_verifier_state(new, false);
> -		kvfree(new_sl);
> +		kfree(new_sl);
>   		return err;
>   	}
>