linux-kernel - Re: [PATCH v1 5/5] drm: panel-backlight-quirks: Add Steam Decks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <198e62c6b4d.895a68a41708589.706102196190635345@collabora.com>
Date: Tue, 26 Aug 2025 12:38:47 +0100
From: Robert Beckett <bob.beckett@...labora.com>
To: "Antheas Kapenekakis" <lkml@...heas.dev>
Cc: "amd-gfx" <amd-gfx@...ts.freedesktop.org>,
	"dri-devel" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"philm" <philm@...jaro.org>,
	"Alex Deucher" <alexander.deucher@....com>,
	"Christian König" <christian.koenig@....com>,
	"Mario Limonciello" <mario.limonciello@....com>
Subject: Re: [PATCH v1 5/5] drm: panel-backlight-quirks: Add Steam Decks


 ---- On Sun, 24 Aug 2025 21:02:02 +0100  Antheas Kapenekakis <lkml@...heas.dev> wrote --- 
 > On the SteamOS kernel, Valve universally makes minimum brightness 0
 > for all devices. SteamOS is (was?) meant for the Steam Deck, so
 > enabling it universally is reasonable. However, it causes issues in
 > certain devices. Therefore, introduce it just for the Steam Deck here.
 > 
 > SteamOS kernel does not have a public mirror, but this replaces commit
 > 806dd74bb225 ("amd/drm: override backlight min value from 12 -> 0")
 > in the latest, as of this writing, SteamOS kernel (6.11.11-valve24).
 > See unofficial mirror reconstructed from sources below.
 > 
 > Link: https://gitlab.com/evlaV/linux-integration/-/commit/806dd74bb225
 > Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
 > ---
 >  drivers/gpu/drm/drm_panel_backlight_quirks.c | 17 ++++++++++++++++-
 >  1 file changed, 16 insertions(+), 1 deletion(-)
 > 
 > diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
 > index 78c430b07d6a..5c24f4a86519 100644
 > --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
 > +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
 > @@ -73,7 +73,22 @@ static const struct drm_get_panel_backlight_quirk drm_panel_min_backlight_quirks
 >          .dmi_match_other.field = DMI_PRODUCT_NAME,
 >          .dmi_match_other.value = "ONEXPLAYER F1 EVA-02",
 >          .quirk = { .brightness_mask = 3, },
 > -    }
 > +    },
 > +    /* Steam Deck models */
 > +    {
 > +        .dmi_match.field = DMI_SYS_VENDOR,
 > +        .dmi_match.value = "Valve",
 > +        .dmi_match_other.field = DMI_PRODUCT_NAME,
 > +        .dmi_match_other.value = "Jupiter",
 > +        .quirk = { .min_brightness = 1, },
 > +    },
 > +    {
 > +        .dmi_match.field = DMI_SYS_VENDOR,
 > +        .dmi_match.value = "Valve",
 > +        .dmi_match_other.field = DMI_PRODUCT_NAME,
 > +        .dmi_match_other.value = "Galileo",
 > +        .quirk = { .min_brightness = 1, },
 > +    },
 >  };
 >  
 >  static bool drm_panel_min_backlight_quirk_matches(
 > -- 
 > 2.50.1
 > 

Reviewed-by: Robert Beckett <bob.beckett@...labora.com>