linux-kernel - Re: [PATCH v3 0/4] efi: stmm: Fix for incorrect buffer allocation and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXH6VifL3Dqts95qs2U8yBqKMOTLMFYVF2nD1QVt4ACKcw@mail.gmail.com>
Date: Tue, 26 Aug 2025 14:54:05 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Sumit Garg <sumit.garg@...nel.org>
Cc: Jan Kiszka <jan.kiszka@...mens.com>, Masahisa Kojima <kojima.masahisa@...ionext.com>, 
	Ilias Apalodimas <ilias.apalodimas@...aro.org>, linux-efi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Jens Wiklander <jens.wiklander@...aro.org>, 
	Hua Qian Li <huaqian.li@...mens.com>
Subject: Re: [PATCH v3 0/4] efi: stmm: Fix for incorrect buffer allocation and cleanups

On Tue, 26 Aug 2025 at 13:00, Sumit Garg <sumit.garg@...nel.org> wrote:
>
> On Mon, Aug 25, 2025 at 06:07:09PM +0200, Jan Kiszka wrote:
> > Changes in v3:
> >  - improve description of patch 3
> >
> > Changes in v2:
> >  - simplify page allocation approach
> >  - switch to returning EFI_DEVICE_ERROR on ENOMEM
> >  - drop efi return value argument from setup_mm_hdr
> >
> > One critical fix for the EFI StMM driver, one error return code
> > adjustment and two smaller cleanups.
> >
> > Note that the suggestion to convert tee_shm_register_kernel_buf to take
> > pages instead of buffer addresses is not forgotten, just in the backlog.
> > I wanted to avoid that the critical fix has to wait for me finding time
> > to refactor the API as well.
> >
> > Jan
> >
> > Jan Kiszka (4):
> >   efi: stmm: Fix incorrect buffer allocation method
> >   efi: stmm: Do not return EFI_OUT_OF_RESOURCES on internal errors
> >   efi: stmm: Drop unused EFI error from setup_mm_hdr arguments
> >   efi: stmm: Drop unneeded null pointer check
> >
> >  drivers/firmware/efi/stmm/tee_stmm_efi.c | 61 +++++++++++-------------
> >  1 file changed, 27 insertions(+), 34 deletions(-)
>
> LGTM, for the series:
>
> Acked-by: Sumit Garg <sumit.garg@....qualcomm.com>
>

Thanks all - I've queued these up now.