linux-kernel - Re: [PATCH next] HID: i2c-hid: Fix test in i2c_hid_core_register_panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEXTbpcpJsL0te+DA=5PEJjkawZ23Di3v20hdMqUj3SeB_Y82w@mail.gmail.com>
Date: Wed, 27 Aug 2025 21:43:10 +0800
From: Pin-yen Lin <treapking@...omium.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, 
	Douglas Anderson <dianders@...omium.org>, Aleksandrs Vinarskis <alex.vinarskis@...il.com>, 
	Wentao Guan <guanwentao@...ontech.com>, 
	Bartłomiej Maryńczak <marynczakbartlomiej@...il.com>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Kenny Levinsen <kl@...wtf>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] HID: i2c-hid: Fix test in i2c_hid_core_register_panel_follower()

Hi Dan,

On Wed, Aug 27, 2025 at 8:57 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> Bitwise AND was intended instead of OR.  With the current code the
> condition is always true.
>
> Fixes: cbdd16b818ee ("HID: i2c-hid: Make elan touch controllers power on after panel is enabled")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 99ce6386176c..30ebde1273be 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -1189,7 +1189,7 @@ static int i2c_hid_core_register_panel_follower(struct i2c_hid *ihid)
>         struct device *dev = &ihid->client->dev;
>         int ret;
>
> -       if (ihid->hid->initial_quirks | HID_QUIRK_POWER_ON_AFTER_BACKLIGHT)
> +       if (ihid->hid->initial_quirks & HID_QUIRK_POWER_ON_AFTER_BACKLIGHT)
>                 ihid->panel_follower.funcs = &i2c_hid_core_panel_follower_enable_funcs;
>         else
>                 ihid->panel_follower.funcs = &i2c_hid_core_panel_follower_prepare_funcs;
> --
> 2.47.2
>

Reviewed-by:  Pin-yen Lin <treapking@...omium.org>

Thanks for catching this!

Regards,
Pin-yen