linux-kernel - Re: [PATCH v2 3/3] HID: tighten ioctl command parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6df083db-b1d5-4c80-96f7-e6b787bd357c@app.fastmail.com>
Date: Wed, 27 Aug 2025 15:45:01 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Benjamin Tissoires" <bentiss@...nel.org>,
 "Jiri Kosina" <jikos@...nel.org>, shuah <shuah@...nel.org>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: linux-input@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] HID: tighten ioctl command parsing

On Tue, Aug 26, 2025, at 14:39, bentiss@...nel.org wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The handling for variable-length ioctl commands in hidraw_ioctl() is
> rather complex and the check for the data direction is incomplete.
>
> Simplify this code by factoring out the various ioctls grouped by dir
> and size, and using a switch() statement with the size masked out, to
> ensure the rest of the command is correctly matched.
>
> Fixes: 9188e79ec3fd ("HID: add phys and name ioctls to hidraw")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Benjamin Tissoires <bentiss@...nel.org>

Hi Benjamin,

Thanks for fixing my botched patch and sending the new version,
looks good to me.

Since you already rewrote most of it, I think this should be attributed
to you though, so maybe make that just 'Reported-by: Arnd Bergmann
<arnd@...db.de>' and make you the author?

    Arnd