linux-kernel - Re: [PATCH v3] block: mtip32xx: Remove excess code in mtip_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09ef0b44eef45a534fc3230e9dfaeebb36a08e44.camel@mailbox.org>
Date: Wed, 27 Aug 2025 15:50:10 +0200
From: Philipp Stanner <phasta@...lbox.org>
To: Zhang Heng <zhangheng@...inos.cn>, axboe@...nel.dk, phasta@...nel.org, 
 andriy.shevchenko@...ux.intel.com, broonie@...nel.org, lizetao1@...wei.com,
  viro@...iv.linux.org.uk, fourier.thomas@...il.com, anuj20.g@...sung.com
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] block: mtip32xx: Remove excess code in mtip_pci_probe

On Wed, 2025-08-27 at 21:12 +0800, Zhang Heng wrote:
> In the error exit function of the iomap_err in mtip_pci_probe,
> pci_set_drvdata(pdev, NULL) and return can be removed without
> affecting the code execution
> 
> Signed-off-by: Zhang Heng <zhangheng@...inos.cn>

Reviewed-by: Philipp Stanner <phasta@...nel.org>

> ---
>  drivers/block/mtip32xx/mtip32xx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 8fc7761397bd..2c33c1dfc39d 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -3840,8 +3840,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,
>  
>  iomap_err:
>  	kfree(dd);
> -	pci_set_drvdata(pdev, NULL);
> -	return rv;
>  done:
>  	return rv;
>  }