linux-kernel - Re: [PATCH v2] PCI: keystone: Use kcalloc() instead of kzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175630347585.12704.14542209032343661928.b4-ty@kernel.org>
Date: Wed, 27 Aug 2025 19:34:35 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>, 
 Krzysztof Wilczyński <kwilczynski@...nel.org>, 
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
 Niklas Cassel <cassel@...nel.org>, Siddharth Vadapalli <s-vadapalli@...com>, 
 Kishon Vijay Abraham I <kishon@...nel.org>, 
 Hans Zhang <18255117159@....com>, 
 Sergio Paracuellos <sergio.paracuellos@...il.com>, 
 "Jiri Slaby (SUSE)" <jirislaby@...nel.org>, linux-pci@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Qianfeng Rong <rongqianfeng@...o.com>
Subject: Re: [PATCH v2] PCI: keystone: Use kcalloc() instead of kzalloc()


On Tue, 19 Aug 2025 21:12:33 +0800, Qianfeng Rong wrote:
> Replace calls of devm_kzalloc() with devm_kcalloc() in ks_pcie_probe().
> As noted in the kernel documentation [1], open-coded multiplication in
> allocator arguments is discouraged because it can lead to integer
> overflow.
> 
> Using devm_kcalloc() provides built-in overflow protection, making the
> memory allocation safer when calculating the allocation size compared
> to explicit multiplication.
> 
> [...]

Applied, thanks!

[1/1] PCI: keystone: Use kcalloc() instead of kzalloc()
      commit: ffdd27d36265be108827c606c9fbe81a5947547e

Best regards,
-- 
Manivannan Sadhasivam <mani@...nel.org>