linux-kernel - Re: [PATCH v2 2/2] arm64: dts: rockchip: add DTs for 100ASK DShanPi A1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250827143006.1001952-1-amadeus@jmu.edu.cn>
Date: Wed, 27 Aug 2025 22:30:06 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: i@...insx.cn
Cc: conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	heiko@...ech.de,
	krzk+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	Chukun Pan <amadeus@....edu.cn>
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: add DTs for 100ASK DShanPi A1

Hi,

> +	vcc_12v0_dcin: regulator-vcc-12v0-dcin {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_12v0_dcin";

>From the schematic [1], it should be called vcc_in?

> +	vcc3v3_pcie: regulator-vcc3v3-pcie {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpios = <&gpio1 RK_PB7 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pcie_pwren_h>;

Schematic: "PCIE0_PERSTn"
It seems that it should be the reset gpio of pcie
instead of the enable of regulator.

> +		regulator-name = "vcc3v3_pcie";
> +		vin-supply = <&vcc_12v0_dcin>;

>From the schematic, it should be called vcc3v3_m2?
VCC5V0_SYS -> VCC3V3_M2

> +	vcc_5v0_sys: regulator-vcc-5v0-sys {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_5v0_sys";

Schematic: "VCC5V0_SYS_S5" / "VCC5V0_SYS"

> +	vcc_5v0_typec0: regulator-vcc-5v0-typec0 {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&usb_otg0_pwren>;

Schematic: "TYPEC5V_PWREN_H"

> +		regulator-name = "vcc_5v0_typec0";
> +		vin-supply = <&vcc_5v0_device>;

Schematic: "VBUS5V0_TYPEC"
VCC5V0_SYS -> VBUS5V0_TYPEC

> +	vcc_5v0_usbhost: regulator-vcc-5v0-usbhost {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;

Does this regulator really exist?
GPIO0_C7_d -> ETH1_INTn

The power supply of USB3 host comes from
USB1_P1_PWR/USB1_P2_PWR - VCC5V0_SYS

> +	vcc_3v3_ufs_s0: regulator-vcc-ufs-s0 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_3v3_ufs_s0";
> +		regulator-boot-on;
> +		regulator-always-on;

The order of properties should be consistent:
```
		regulator-always-on;
		regulator-boot-on;
```

> +&i2c2 {
> +	status = "okay";
> +
> +	hym8563: rtc@51 {
> +		compatible = "haoyu,hym8563";
> +		reg = <0x51>;
> +		clock-output-names = "hym8563";
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PA0 IRQ_TYPE_LEVEL_LOW>;

GPIO0_A0 is connected to the button in the schematic [1]

[1] https://dl.100ask.net/Hardware/MPU/RK3576-DshanPi-A1/DshanPi-A1-RK3576-SCH_V1.0.pdf

--
2.25.1