linux-kernel - Re: [PATCH] rust: use the new name Location::file_as_c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK8co_CHsqr4gBhe@tardis-2.local>
Date: Wed, 27 Aug 2025 07:56:35 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, linux-kernel@...r.kernel.org,
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: use the new name Location::file_as_c_str() in
 rustc 1.91.0+

On Wed, Aug 27, 2025 at 01:12:16PM +0000, Alice Ryhl wrote:
> As part of the stabilization of Location::file_with_nul(), it was
> brought up that the with_nul() suffix usually means something else in
> Rust APIs, so the API is being renamed prior to stabilization. Thus,
> adjust Linux to use the new name on new rustc versions.
> 
> Link: https://www.github.com/rust-lang/rust/pull/145928 [1]
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

Thanks for doing this!

Reviewed-by: Boqun Feng <boqun.feng@...il.com>

> ---
> This hasn't been merged upstream yet. It shouldn't be merged until that
> happens.

Let me know when it gets upstreamed, I'm happy to do a test then.

Regards,
Boqun

> ---
>  init/Kconfig       |  3 +++
>  rust/kernel/lib.rs | 15 +++++++++------
>  2 files changed, 12 insertions(+), 6 deletions(-)
[...]