linux-kernel - Re: [PATCH] media: synopsys: hdmirx: media: Remove redundant ternary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e4804dd-cb6d-4e3e-b964-633ae710c7df@collabora.com>
Date: Wed, 27 Aug 2025 19:44:35 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>,
 Shreeya Patel <shreeya.patel@...labora.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 "open list:SYNOPSYS DESIGNWARE HDMI RX CONTROLLER DRIVER"
 <linux-media@...r.kernel.org>,
 "open list:SYNOPSYS DESIGNWARE HDMI RX CONTROLLER DRIVER"
 <kernel@...labora.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: synopsys: hdmirx: media: Remove redundant ternary
 operators

On 8/26/25 17:50, Liao Yuanhong wrote:
> For ternary operators in the form of a ? true : false, if a itself returns
> a boolean result, the ternary operator can be omitted. Remove redundant
> ternary operators to clean up the code.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index b7d278b3889f..c3007e09bc9f 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -237,7 +237,7 @@ static bool tx_5v_power_present(struct snps_hdmirx_dev *hdmirx_dev)
>  			break;
>  	}
>  
> -	ret = (cnt >= detection_threshold) ? true : false;
> +	ret = cnt >= detection_threshold;
>  	v4l2_dbg(3, debug, &hdmirx_dev->v4l2_dev, "%s: %d\n", __func__, ret);
>  
>  	return ret;

Acked-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>

-- 
Best regards,
Dmitry