linux-kernel - Re: [PATCH] drm/amd/display: use max() to improve code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_OCNrW8jtbfchsZcZAbVt5AOZaLuBOPCHGePxvpU_T0aA@mail.gmail.com>
Date: Wed, 27 Aug 2025 16:09:48 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	Rodrigo Siqueira <siqueira@...lia.com>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Austin Zheng <austin.zheng@....com>, 
	Jun Lei <jun.lei@....com>, Dillon Varone <dillon.varone@....com>, Alvin Lee <Alvin.Lee2@....com>, 
	Ivan Lipski <ivan.lipski@....com>, Tom Chung <chiahsuan.chung@....com>, 
	Clayton King <clayton.king@....com>, Sung Lee <Sung.Lee@....com>, Alex Hung <alex.hung@....com>, 
	Samson Tam <Samson.Tam@....com>, Aurabindo Pillai <aurabindo.pillai@....com>, 
	Karthi Kandasamy <karthi.kandasamy@....com>, Wenjing Liu <wenjing.liu@....com>, 
	Rafal Ostrowski <rostrows@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: use max() to improve code

Applied.  Thanks!

Alex

On Sat, Aug 16, 2025 at 10:49 AM Qianfeng Rong <rongqianfeng@...o.com> wrote:
>
> Use max() to reduce the code and improve readability.
>
> No functional changes.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  .../gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c   | 7 ++-----
>  .../gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c | 6 +-----
>  .../amd/display/dc/dml2/dml21/dml21_translation_helper.c   | 6 +-----
>  3 files changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> index 084994c650c4..8376e2b0e73d 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> @@ -1047,11 +1047,8 @@ static void dcn32_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
>                         &num_entries_per_clk->num_fclk_levels);
>         clk_mgr_base->bw_params->dc_mode_limit.fclk_mhz = dcn30_smu_get_dc_mode_max_dpm_freq(clk_mgr, PPCLK_FCLK);
>
> -       if (num_entries_per_clk->num_memclk_levels >= num_entries_per_clk->num_fclk_levels) {
> -               num_levels = num_entries_per_clk->num_memclk_levels;
> -       } else {
> -               num_levels = num_entries_per_clk->num_fclk_levels;
> -       }
> +       num_levels = max(num_entries_per_clk->num_memclk_levels, num_entries_per_clk->num_fclk_levels);
> +
>         clk_mgr_base->bw_params->max_memclk_mhz =
>                         clk_mgr_base->bw_params->clk_table.entries[num_entries_per_clk->num_memclk_levels - 1].memclk_mhz;
>         clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c
> index b59703467128..47ff4c965d76 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c
> @@ -1404,11 +1404,7 @@ static void dcn401_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
>                         clk_mgr_base->bw_params->clk_table.entries[num_entries_per_clk->num_fclk_levels - 1].fclk_mhz)
>                 clk_mgr_base->bw_params->dc_mode_limit.fclk_mhz = 0;
>
> -       if (num_entries_per_clk->num_memclk_levels >= num_entries_per_clk->num_fclk_levels) {
> -               num_levels = num_entries_per_clk->num_memclk_levels;
> -       } else {
> -               num_levels = num_entries_per_clk->num_fclk_levels;
> -       }
> +       num_levels = max(num_entries_per_clk->num_memclk_levels, num_entries_per_clk->num_fclk_levels);
>
>         clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c
> index a06217a9eef6..21cc30f9b8a8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c
> @@ -463,11 +463,7 @@ static void populate_dml21_timing_config_from_stream_state(struct dml2_timing_cf
>                                 (stream->timing.h_total * (long long)calc_max_hardware_v_total(stream)));
>         }
>
> -       if (stream->timing.min_refresh_in_uhz > min_hardware_refresh_in_uhz) {
> -               timing->drr_config.min_refresh_uhz = stream->timing.min_refresh_in_uhz;
> -       } else {
> -               timing->drr_config.min_refresh_uhz = min_hardware_refresh_in_uhz;
> -       }
> +       timing->drr_config.min_refresh_uhz = max(stream->timing.min_refresh_in_uhz, min_hardware_refresh_in_uhz);
>
>         if (dml_ctx->config.callbacks.get_max_flickerless_instant_vtotal_increase &&
>                         stream->ctx->dc->config.enable_fpo_flicker_detection == 1)
> --
> 2.34.1
>