linux-kernel - Re: [PATCH v7 0/2] bpftool: Refactor config parsing and add CET symbol matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bzb_3ac0dPnkuMqs-dCrTEWqjVt-fsGWGyHAai_bUxubNA@mail.gmail.com>
Date: Wed, 27 Aug 2025 14:53:23 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: chenyuan_fl@....com, Quentin Monnet <qmo@...nel.org>
Cc: olsajiri@...il.com, aef2617b-ce03-4830-96a7-39df0c93aaad@...nel.org, 
	andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org, chenyuan@...inos.cn, 
	daniel@...earbox.net, linux-kernel@...r.kernel.org, yonghong.song@...ux.dev
Subject: Re: [PATCH v7 0/2] bpftool: Refactor config parsing and add CET
 symbol matching

On Sun, Aug 24, 2025 at 7:20 PM <chenyuan_fl@....com> wrote:
>
> From: Yuan CHen <chenyuan@...inos.cn>
>
> 1. **Refactor kernel config parsing**
>    - Moves duplicate config file handling from feature.c to common.c
>    - Keeps all existing functionality while enabling code reuse
>
> 2. **Add CET-aware symbol matching**
>    - Adjusts kprobe hook detection for x86_64 CET (endbr32/64 prefixes)
>    - Matches symbols at both original and CET-adjusted addresses
>

Quentin, can you please take a quick look at this patch set, when you
get a chance? Thanks!

> Changed in PATCH v4:
> * Refactor repeated code into a function.
> * Add detection for the x86 architecture.
>
> Changed int PATH v5:
> * Remove detection for the x86 architecture.
>
>  Changed in PATCH v6:
> * Add new helper patch (1/2) to refactor kernel config reading
> * Use the new read_kernel_config() in CET symbol matching (2/2) to check CONFIG_X86_KERNEL_IBT
>
> Changed in PATCH v7:
> * Display actual kprobe attachment addresses instead of symbol addresses
>
> Yuan Chen (2):
>   bpftool: Refactor kernel config reading into common helper
>   bpftool: Add CET-aware symbol matching for x86_64 architectures
>
>  tools/bpf/bpftool/common.c  | 93 +++++++++++++++++++++++++++++++++++++
>  tools/bpf/bpftool/feature.c | 86 ++--------------------------------
>  tools/bpf/bpftool/link.c    | 38 ++++++++++++++-
>  tools/bpf/bpftool/main.h    |  9 ++++
>  4 files changed, 142 insertions(+), 84 deletions(-)
>
> --
> 2.39.5
>