linux-kernel - Re: [PATCH bpf-next v16 2/2] selftests/bpf: Enrich subtest_basic_usdt case in selftests to cover SIB handling logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzawZtJJvnMqDp2E7Z=tr9tFvkfA3+w8m9G3TfhsP8eYhA@mail.gmail.com>
Date: Wed, 27 Aug 2025 15:51:16 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Jiawei Zhao <phoenix500526@....com>
Cc: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, 
	yonghong.song@...ux.dev, bpf@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v16 2/2] selftests/bpf: Enrich subtest_basic_usdt
 case in selftests to cover SIB handling logic

On Tue, Aug 26, 2025 at 10:31 PM Jiawei Zhao <phoenix500526@....com> wrote:
>
> When using GCC on x86-64 to compile an usdt prog with -O1 or higher
> optimization, the compiler will generate SIB addressing mode for global
> array, e.g. "1@-96(%rbp,%rax,8)".
>
> In this patch:
> - enrich subtest_basic_usdt test case to cover SIB addressing usdt argument spec
>   handling logic
>
> Signed-off-by: Jiawei Zhao <phoenix500526@....com>
> ---
>  tools/testing/selftests/bpf/prog_tests/usdt.c | 84 ++++++++++++++++++-
>  tools/testing/selftests/bpf/progs/test_usdt.c | 31 +++++++
>  2 files changed, 113 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/usdt.c b/tools/testing/selftests/bpf/prog_tests/usdt.c
> index 9057e983cc54..9df2827991c7 100644
> --- a/tools/testing/selftests/bpf/prog_tests/usdt.c
> +++ b/tools/testing/selftests/bpf/prog_tests/usdt.c
> @@ -25,6 +25,7 @@ unsigned short test_usdt0_semaphore SEC(".probes");
>  unsigned short test_usdt3_semaphore SEC(".probes");
>  unsigned short test_usdt12_semaphore SEC(".probes");
>
> +

next time don't add random empty lines or unrelated formatting changes
(I fixed this up as well while applying)

>  static void __always_inline trigger_func(int x) {
>         long y = 42;
>

[...]