linux-kernel - Re: [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250827225818.GA916741@bhelgaas>
Date: Wed, 27 Aug 2025 17:58:18 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Marc Zyngier <maz@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Anders Roxell <anders.roxell@...aro.org>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, Longbin Li <looong.bin@...il.com>,
	Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in
 cond_[startup|shutdown]_parent()

On Thu, Aug 28, 2025 at 06:52:39AM +0800, Inochi Amaoto wrote:
> On Wed, Aug 27, 2025 at 01:32:02PM -0500, Bjorn Helgaas wrote:
> > On Wed, Aug 27, 2025 at 02:29:07PM +0800, Inochi Amaoto wrote:
> > > For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT,
> > > the newly added callback irq_startup() and irq_shutdown() for
> > > pci_msi[x]_templete will not unmask/mask the interrupt when startup/
> > > shutdown the interrupt. This will prevent the interrupt from being
> > > enabled/disabled normally.
> > 
> > s/templete/template/
> 
> > AFAICS cond_startup_parent() is used by pci_irq_startup_msi() and
> > pci_irq_startup_msix() in pci_msi_template; cond_shutdown_parent() is
> > used by pci_irq_shutdown_msi() and pci_irq_shutdown_msix() in
> > pci_msix_template.
> 
> cond_startup_parent() is used by pci_irq_startup_msi() in
> pci_msi_template and pci_irq_startup_msix() in pci_msix_template;
> cond_shutdown_parent() is used by pci_irq_shutdown_msi() in
> pci_msi_template and pci_irq_shutdown_msix() in pci_msix_template.

Right, I really screwed that up when I noticed the "*_template"
structure names and added them to my description.