linux-kernel - [PATCH v2 09/10] PCI: aspeed: Add ASPEED PCIe RC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB5134C10E219E40C76D1413579D38A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Wed, 27 Aug 2025 03:45:09 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Markus Elfring <Markus.Elfring@....de>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Andrew Jeffery
	<andrew@...econstruct.com.au>, Bjorn Helgaas <bhelgaas@...gle.com>, Conor
 Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Krzysztof Wilczyński
	<kwilczynski@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Lorenzo
 Pieralisi <lpieralisi@...nel.org>, Manivannan Sadhasivam <mani@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>
Subject: [PATCH v2 09/10] PCI: aspeed: Add ASPEED PCIe RC driver

Hi Markus,

Thank you for your reply.

> > +++ b/drivers/pci/controller/pcie-aspeed.c
> > @@ -0,0 +1,1137 @@
> …
> > +static int aspeed_irq_msi_domain_alloc(struct irq_domain *domain,
> > +				       unsigned int virq, unsigned int nr_irqs,
> > +				       void *args)
> > +{
> …
> > +	mutex_lock(&pcie->lock);
> > +
> > +	bit = bitmap_find_free_region(pcie->msi_irq_in_use,
> MAX_MSI_HOST_IRQS,
> > +				      get_count_order(nr_irqs));
> > +
> > +	mutex_unlock(&pcie->lock);
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&pcie->lock);”?
> https://elixir.bootlin.com/linux/v6.16-rc6/source/include/linux/mutex.h#L225
> 

Thanks for the information that made me know this method.
I just referred to the existed drivers in Linux before, and it seems there are a lot of drivers keeping the original usage.
So, I have no idea Linux have introduced these methods.
I will take care of these usages in my develop and will change it in this driver in next version.

Thanks,
Jacky