linux-kernel - Re: [PATCH v2 0/8] gpu: nova-core: process and prepare more firmwares to boot GSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc18894e-09d3-4088-9be0-22c2070b61f4@nvidia.com>
Date: Tue, 26 Aug 2025 17:29:45 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: Alistair Popple <apopple@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
 nouveau@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 0/8] gpu: nova-core: process and prepare more firmwares
 to boot GSP

On 8/25/25 9:07 PM, Alexandre Courbot wrote:
...
> The base of this series is today's nova-next, but there a few more
> unmerged dependencies required:
> 
> - BorrowedPage, AsPageIter and VmallocPageIter [2]
> - Rust infrastructure for sg_table and scatterlist [3]
> - FromBytes [4]
> - The Alignment series [5]

Hi Alex!

For future patchsets that have complex and/or lengthy prerequisite
patchsets, let's please please make it easier for people to
locally apply the series. Very important. 

The very nicest experience is by simply providing a link to your git
branch that exactly matches the patchset you just posted.

In this particular case, it would also have worked to just say, "this 
series can be applied by first applying FromBytes [4], to the base commit."

Because that works, and is simpler than hunting down the other three
items, which are not actually necessary for git am (although they
might be for actual testing).

But the point is that the admin can be made simpler for the reviewers--even
those of us who know exactly what you're up to. And we should keep
that in mind, especially because there are many more of these situations
coming soon.

thanks,
-- 
John Hubbard