linux-kernel - Re: [PATCH v3 3/4] auxdisplay: Add TM16xx 7-segment LED matrix display controllers driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202508271344.WqQr2aa7-lkp@intel.com>
Date: Wed, 27 Aug 2025 13:32:42 +0800
From: kernel test robot <lkp@...el.com>
To: Jean-François Lessard <jefflessard3@...il.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andreas Färber <afaerber@...e.de>,
	Boris Gjenero <boris.gjenero@...il.com>,
	Christian Hewitt <christianshewitt@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Paolo Sabatino <paolo.sabatino@...il.com>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH v3 3/4] auxdisplay: Add TM16xx 7-segment LED matrix
 display controllers driver

Hi Jean-François,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.17-rc3 next-20250826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jean-Fran-ois-Lessard/dt-bindings-vendor-prefixes-Add-fdhisi-titanmec-princeton-winrise-wxicore/20250821-003451
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250820163120.24997-4-jefflessard3%40gmail.com
patch subject: [PATCH v3 3/4] auxdisplay: Add TM16xx 7-segment LED matrix display controllers driver
config: x86_64-randconfig-r112-20250827 (https://download.01.org/0day-ci/archive/20250827/202508271344.WqQr2aa7-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250827/202508271344.WqQr2aa7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508271344.WqQr2aa7-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: vmlinux.o: in function `tm16xx_i2c_write':
>> drivers/auxdisplay/tm16xx.c:1469: undefined reference to `i2c_transfer'
   ld: vmlinux.o: in function `tm16xx_i2c_read':
   drivers/auxdisplay/tm16xx.c:1497: undefined reference to `i2c_transfer'
   ld: vmlinux.o: in function `tm16xx_i2c_probe':
>> drivers/auxdisplay/tm16xx.c:1416: undefined reference to `i2c_get_match_data'
   ld: vmlinux.o: in function `tm16xx_i2c_register':
>> drivers/auxdisplay/tm16xx.c:1727: undefined reference to `i2c_register_driver'
   ld: vmlinux.o: in function `tm16xx_i2c_unregister':
>> drivers/auxdisplay/tm16xx.c:1732: undefined reference to `i2c_del_driver'


vim +1469 drivers/auxdisplay/tm16xx.c

  1401	
  1402	/* I2C specific code */
  1403	#if IS_ENABLED(CONFIG_I2C)
  1404	/**
  1405	 * tm16xx_i2c_probe() - Probe callback for I2C-attached controllers
  1406	 * @client: pointer to i2c_client
  1407	 *
  1408	 * Return: 0 on success, negative error code on failure
  1409	 */
  1410	static int tm16xx_i2c_probe(struct i2c_client *client)
  1411	{
  1412		const struct tm16xx_controller *controller;
  1413		struct tm16xx_display *display;
  1414		int ret;
  1415	
> 1416		controller = i2c_get_match_data(client);
  1417		if (!controller)
  1418			return -EINVAL;
  1419	
  1420		display = devm_kzalloc(&client->dev, sizeof(*display), GFP_KERNEL);
  1421		if (!display)
  1422			return -ENOMEM;
  1423	
  1424		display->client.i2c = client;
  1425		display->dev = &client->dev;
  1426		display->controller = controller;
  1427	
  1428		i2c_set_clientdata(client, display);
  1429	
  1430		ret = tm16xx_probe(display);
  1431		if (ret)
  1432			return ret;
  1433	
  1434		return 0;
  1435	}
  1436	
  1437	/**
  1438	 * tm16xx_i2c_remove() - Remove callback for I2C-attached controllers
  1439	 * @client: pointer to i2c_client
  1440	 */
  1441	static void tm16xx_i2c_remove(struct i2c_client *client)
  1442	{
  1443		struct tm16xx_display *display = i2c_get_clientdata(client);
  1444	
  1445		tm16xx_display_remove(display);
  1446	}
  1447	
  1448	/**
  1449	 * tm16xx_i2c_write() - I2C write helper for controller
  1450	 * @display: pointer to tm16xx_display structure
  1451	 * @data: command and data bytes to send
  1452	 * @len: number of bytes in @data
  1453	 *
  1454	 * Return: 0 on success, negative error code on failure
  1455	 */
  1456	static int tm16xx_i2c_write(struct tm16xx_display *display, u8 *data, size_t len)
  1457	{
  1458		dev_dbg(display->dev, "i2c_write %*ph", (char)len, data);
  1459	
  1460		/* expected sequence: S Command [A] Data [A] P */
  1461		struct i2c_msg msg = {
  1462			.addr = data[0] >> 1,
  1463			.flags = 0,
  1464			.len = len - 1,
  1465			.buf = &data[1],
  1466		};
  1467		int ret;
  1468	
> 1469		ret = i2c_transfer(display->client.i2c->adapter, &msg, 1);
  1470		if (ret < 0)
  1471			return ret;
  1472	
  1473		return (ret == 1) ? 0 : -EIO;
  1474	}
  1475	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki