linux-kernel - Re: [PATCH][next] scsi: fc: Avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3988bb4-a51e-4d7e-90d6-7c37020cd1b4@embeddedor.com>
Date: Wed, 27 Aug 2025 07:54:09 +0200
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Justin Tee <justintee8345@...il.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: James Smart <james.smart@...adcom.com>,
 Justin Tee <justin.tee@...adcom.com>, Hannes Reinecke <hare@...e.de>,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] scsi: fc: Avoid -Wflex-array-member-not-at-end
 warnings

On 27/08/25 01:13, Justin Tee wrote:
> Hi Martin and Gustavo,
> 
> Regarding the maintainers file, yes Broadcom will push a patch to update soon.
> 
> Regarding Gustavo’s patch, I think we should also update the
> assignment of rdf.desc_len in lpfc_els.c like below.
> 
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index fca81e0c7c2e..432761fb49de 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -3762,7 +3762,7 @@ lpfc_issue_els_rdf(struct lpfc_vport *vport,
> uint8_t retry)
>          memset(prdf, 0, cmdsize);
>          prdf->rdf.fpin_cmd = ELS_RDF;
>          prdf->rdf.desc_len = cpu_to_be32(sizeof(struct lpfc_els_rdf_req) -
> -                                        sizeof(struct fc_els_rdf));
> +                                        sizeof(struct fc_els_rdf_hdr));

Good catch! :)

Thanks
-Gustavo