linux-kernel - Re: [PATCH] staging: rtl8723bs: drop redundant conversion to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK67oBH4cQ10C4A6@stanley.mountain>
Date: Wed, 27 Aug 2025 11:02:40 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Xichao Zhao <zhao.xichao@...o.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: drop redundant conversion to bool

On Wed, Aug 27, 2025 at 11:15:00AM +0800, Xichao Zhao wrote:
> The result of integer comparison already evaluates to bool. No need for
> explicit conversion.
> 
> No functional impact.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c        | 6 +++---
>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 692d0c2b766d..570c99192d3f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -1597,7 +1597,7 @@ inline bool rtw_is_scan_deny(struct adapter *adapter)
>  {
>  	struct mlme_priv *mlmepriv = &adapter->mlmepriv;
>  
> -	return (atomic_read(&mlmepriv->set_scan_deny) != 0) ? true : false;
> +	return (atomic_read(&mlmepriv->set_scan_deny) != 0);


mlmepriv->set_scan_deny is either 0 or 1 so it's cleaner to just do:

	return atomic_read(&mlmepriv->set_scan_deny);

(avoids the double negative).

regards,
dan carpenter