linux-kernel - Re: [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05c468dd-526d-4367-8e24-98647d5232fd@kernel.org>
Date: Wed, 27 Aug 2025 10:23:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gary Yang <gary.yang@...tech.com>, linus.walleij@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com
Subject: Re: [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1

On 27/08/2025 04:42, Gary Yang wrote:
>  			};
>  		};
> +
> +		iomuxc: pinctrl@...0000 {
> +			compatible = "cix,sky1-iomuxc";
> +			reg = <0x0 0x04170000 0x0 0x1000>;
> +		};
> +
> +		iomuxc_s5: pinctrl@...07000 {

Are you sure you follow DTS coding style for ordering of nodes? Looks
like you just keep adding things to the end...

> +			compatible = "cix,sky1-iomuxc-s5";
> +			reg = <0x0 0x16007000 0x0 0x1000>;
> +		};
>  	};
>  
>  	timer {


Best regards,
Krzysztof