linux-kernel - Re: [PATCH] drivers: perf: use us_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aK7RkB5p6L17Ffuw@J2N7QTR9R3>
Date: Wed, 27 Aug 2025 10:36:16 +0100
From: Mark Rutland <mark.rutland@....com>
To: Xichao Zhao <zhao.xichao@...o.com>
Cc: will@...nel.org, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org, robin.murphy@....com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drivers: perf: use us_to_ktime() where appropriate

[adding Robin and LAKML]

On Wed, Aug 13, 2025 at 04:32:57PM +0800, Xichao Zhao wrote:
> The arm_ccn_pmu_poll_period_us are more suitable for using
> the us_to_ktime(). This can make the code more concise and
> enhance readability.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>

Superficially this looks fine to me, so:

Acked-by: Mark Rutland <mark.rutland@....com>

Will, I assume that (if no-one complains) you'll pick this up when
queueing PMU patches.

Mark.

> ---
>  drivers/perf/arm-ccn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
> index 1a0d0e1a2263..8af3563fdf60 100644
> --- a/drivers/perf/arm-ccn.c
> +++ b/drivers/perf/arm-ccn.c
> @@ -565,7 +565,7 @@ module_param_named(pmu_poll_period_us, arm_ccn_pmu_poll_period_us, uint,
>  
>  static ktime_t arm_ccn_pmu_timer_period(void)
>  {
> -	return ns_to_ktime((u64)arm_ccn_pmu_poll_period_us * 1000);
> +	return us_to_ktime((u64)arm_ccn_pmu_poll_period_us);
>  }
>  
>  
> -- 
> 2.34.1
>