linux-kernel - Re: [PATCH v4] perf/x86/zhaoxin: Fix instructions error by missing fixedctr member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <692c463d-69e4-4044-b13b-3538bd695283@163.com>
Date: Wed, 27 Aug 2025 17:36:39 +0800
From: tanze <tanze0x01@....com>
To: peterz@...radead.org, mingo@...hat.com, acme@...nel.org
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [PATCH v4] perf/x86/zhaoxin: Fix instructions error by missing
 fixedctr member



在 2025/8/14 17:33, tanze0x01@....com 写道:
> From: tanze <tanze0x01@....com>
> 
> Perf's instructions event tests on Zhaoxin CPUs may exhibit:
> 
>    $perf stat -e instructions,cycles ls -l
> 
>    ......
>    Performance counter stats for 'ls -l':
> 
>                   0      instructions                     #    0.00  insn per cycle
>           9,488,278      cycles
> 
>         0.004365407 seconds time elapsed
> 
>         0.003303000 seconds user
>         0.001099000 seconds sys
> 
> The absence of the fixedctr member leads to an incorrect hwc->event_base
> value on Zhaoxin CPUs, causing a discrepancy in the instruction count
> reported by perf stat. This commit resolves the instruction count issue
> by properly initializing the fixedctr member.
> 
> Fixes: 149fd4712bcd ("perf/x86/intel: Support Perfmon MSRs aliasing")
> Signed-off-by: tanze <tanze0x01@....com>
> Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>
> 
> ---
> v1-v3:https://lore.kernel.org/all/20250620023757.1429898-1-tanze@kylinos.cn/
> 
> This patch does not modify the previous code,
> Do you have any other suggestions?
> 
Hi peterz,

This is a friendly ping on this patch.

It has been reviewed by Kan Liang a couple of months ago. Is there 
anything I can do to help get it merged?

Thanks,