linux-kernel - Re: [PATCH v2 0/2] mm/slub: Fix debugfs stack trace sorting and simplify sort call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <229010f4-a68c-400a-94bf-4532ee451ef5@suse.cz>
Date: Wed, 27 Aug 2025 11:55:46 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Kuan-Wei Chiu <visitorckw@...il.com>, akpm@...ux-foundation.org
Cc: cl@...two.org, rientjes@...gle.com, roman.gushchin@...ux.dev,
 harry.yoo@...cle.com, glittao@...il.com, jserv@...s.ncku.edu.tw,
 chuang@...nycu.edu.tw, cfmc.cs13@...u.edu.tw, jhcheng.cs13@...u.edu.tw,
 c.yuanhaur@...tl.edu, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] mm/slub: Fix debugfs stack trace sorting and
 simplify sort call

On 8/26/25 08:23, Kuan-Wei Chiu wrote:
> Fix the comparison function used for sorting stack trace locations in
> the slub debugfs interface. The original implementation violated the
> antisymmetry property required by sort(), which could lead to
> unreliable ordering of the output. The patches correct the comparison
> function to return 0 when counts are equal and replace the unnecessary
> use of sort_r() with the simpler sort().
> ---
> Changes in v2:
> * Use cmp_int().
> * Drop Cc stable. 
> 
> v1: https://lore.kernel.org/lkml/20250825013419.240278-1-visitorckw@gmail.com/
> 
> Kuan-Wei Chiu (2):
>   mm/slub: Fix cmp_loc_by_count() to return 0 when counts are equal
>   mm/slub: Replace sort_r() with sort() for debugfs stack trace sorting

Applied to slab/for-next, thanks!

>  mm/slub.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>