linux-kernel - Re: [PATCH] mmc: sdio: Drop dev_pm_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrWOkDvfNmwTDVGC0VAFb_f0jA+vWas5cUEaPTt2t82=w@mail.gmail.com>
Date: Wed, 27 Aug 2025 13:33:57 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: mathieu.poirier@...aro.org, rafael.j.wysocki@...el.com, 
	wsa+renesas@...g-engineering.com, rafael@...nel.org, 
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH] mmc: sdio: Drop dev_pm_domain_detach() call

On Wed, 27 Aug 2025 at 12:12, Claudiu <claudiu.beznea@...on.dev> wrote:
>
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> Starting with commit f99508074e78 ("PM: domains: Detach on
> device_unbind_cleanup()"), there is no longer a need to call
> dev_pm_domain_detach() in the bus remove function. The
> device_unbind_cleanup() function now handles this to avoid
> invoking devres cleanup handlers while the PM domain is
> powered off, which could otherwise lead to failures as
> described in the above-mentioned commit.
>
> Drop the explicit dev_pm_domain_detach() call and rely instead
> on the flags passed to dev_pm_domain_attach() to power off the
> domain.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/sdio_bus.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c
> index 656601754966..10799772494a 100644
> --- a/drivers/mmc/core/sdio_bus.c
> +++ b/drivers/mmc/core/sdio_bus.c
> @@ -200,7 +200,6 @@ static int sdio_bus_probe(struct device *dev)
>         atomic_dec(&func->card->sdio_funcs_probed);
>         if (func->card->host->caps & MMC_CAP_POWER_OFF_CARD)
>                 pm_runtime_put_noidle(dev);
> -       dev_pm_domain_detach(dev, false);
>         return ret;
>  }
>
> @@ -231,8 +230,6 @@ static void sdio_bus_remove(struct device *dev)
>         /* Then undo the runtime PM settings in sdio_bus_probe() */
>         if (func->card->host->caps & MMC_CAP_POWER_OFF_CARD)
>                 pm_runtime_put_sync(dev);
> -
> -       dev_pm_domain_detach(dev, false);
>  }
>
>  static const struct dev_pm_ops sdio_bus_pm_ops = {
> --
> 2.43.0
>