linux-kernel - Re: [PATCH] spi: Drop dev_pm_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFq7xLJfFBZe2UPfErmntfSSo5kt6UpNQs4+vjWFcMK9rA@mail.gmail.com>
Date: Wed, 27 Aug 2025 13:35:50 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: broonie@...nel.org, rafael@...nel.org, linux-spi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH] spi: Drop dev_pm_domain_detach() call

On Wed, 27 Aug 2025 at 12:16, Claudiu <claudiu.beznea@...on.dev> wrote:
>
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> Starting with commit f99508074e78 ("PM: domains: Detach on
> device_unbind_cleanup()"), there is no longer a need to call
> dev_pm_domain_detach() in the bus remove function. The
> device_unbind_cleanup() function now handles this to avoid
> invoking devres cleanup handlers while the PM domain is
> powered off, which could otherwise lead to failures as
> described in the above-mentioned commit.
>
> Drop the explicit dev_pm_domain_detach() call and rely instead
> on the flags passed to dev_pm_domain_attach() to power off the
> domain.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe


> ---
>  drivers/spi/spi.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index a388f372b27a..f95c4304df8e 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -427,15 +427,13 @@ static int spi_probe(struct device *dev)
>         if (spi->irq < 0)
>                 spi->irq = 0;
>
> -       ret = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON);
> +       ret = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON |
> +                                       PD_FLAG_DETACH_POWER_OFF);
>         if (ret)
>                 return ret;
>
> -       if (sdrv->probe) {
> +       if (sdrv->probe)
>                 ret = sdrv->probe(spi);
> -               if (ret)
> -                       dev_pm_domain_detach(dev, true);
> -       }
>
>         return ret;
>  }
> @@ -446,8 +444,6 @@ static void spi_remove(struct device *dev)
>
>         if (sdrv->remove)
>                 sdrv->remove(to_spi_device(dev));
> -
> -       dev_pm_domain_detach(dev, true);
>  }
>
>  static void spi_shutdown(struct device *dev)
> --
> 2.43.0
>