linux-kernel - Re: [PATCH v2 3/9] dt-bindings: iommu: apple,sart: Add Apple A11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3147ebf4-054c-4777-811f-86d0ad14caf6@kernel.org>
Date: Wed, 27 Aug 2025 15:20:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rob Herring <robh@...nel.org>, Nick Chan <towinchenmi@...il.com>
Cc: Sven Peter <sven@...nel.org>, Janne Grunau <j@...nau.net>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa <neal@...pa.dev>,
 Jassi Brar <jassisinghbrar@...il.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Hector Martin <marcan@...can.st>,
 Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
 Robin Murphy <robin.murphy@....com>, Keith Busch <kbusch@...nel.org>,
 Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
 Sagi Grimberg <sagi@...mberg.me>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, iommu@...ts.linux.dev,
 linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v2 3/9] dt-bindings: iommu: apple,sart: Add Apple A11

On 21/08/2025 00:20, Rob Herring wrote:
> On Mon, Aug 18, 2025 at 04:42:56PM +0800, Nick Chan wrote:
>> Add bindings for SARTv0 as found on Apple A11 SoC.
>>
>> Reviewed-by: Sven Peter <sven@...nel.org>
>> Signed-off-by: Nick Chan <towinchenmi@...il.com>
>> ---
>>  Documentation/devicetree/bindings/iommu/apple,sart.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/apple,sart.yaml b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
>> index e87c1520fea60a2de549aa8a469fcded52e3b6e3..95d55ec688779bd52b8aef316a4c1ba7b7449574 100644
>> --- a/Documentation/devicetree/bindings/iommu/apple,sart.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
>> @@ -29,6 +29,7 @@ description:
>>  properties:
>>    compatible:
>>      oneOf:
>> +      - const: apple,t8015-sart
> 
> Actually I take back my ack, move this to the existing 'enum' down 
> below. With that change, you can keep the ack.

What commit fails to explain (folks, please fix that) is that device is
incompatible with existing ones. Right?

Commit should describe the hardware or any unusual things here. Not
making devices compatible, while usually they were compatible, is the
unusual thing.
Best regards,
Krzysztof