linux-kernel - Re: [PATCH v7 0/6] rust, nova-core: PCI Class, Vendor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCE3GFGMZ01P.267QJWUCG4JMQ@nvidia.com>
Date: Thu, 28 Aug 2025 22:27:21 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "John Hubbard" <jhubbard@...dia.com>, "Danilo Krummrich"
 <dakr@...nel.org>
Cc: "Joel Fernandes" <joelagnelf@...dia.com>, "Timur Tabi"
 <ttabi@...dia.com>, "Alistair Popple" <apopple@...dia.com>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Bjorn Helgaas"
 <bhelgaas@...gle.com>, Krzysztof Wilczyński
 <kwilczynski@...nel.org>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, <nouveau@...ts.freedesktop.org>,
 <linux-pci@...r.kernel.org>, <rust-for-linux@...r.kernel.org>, "LKML"
 <linux-kernel@...r.kernel.org>, "Elle Rhumsaa" <elle@...thered-steel.dev>
Subject: Re: [PATCH v7 0/6] rust, nova-core: PCI Class, Vendor support

On Wed Aug 27, 2025 at 8:12 AM JST, John Hubbard wrote:
> Changes since v6:
>
> * Applied changes from Danilo's and Alex's and Elle's reviews (thanks!):
>     * Rebased onto driver-core-next, which is here:
>           https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
>     * Changed pci::Vendor to be a u16, instead of a u32.
>     * Inlined all of the tiniest functions.
>     * Changed from Class/Vendor new(), to from_raw().
>     * Made from_raw() only accessible to super, which in this case is
>       the pci module.
>     * Restored infallible operations. That causes Alex's request for the
>       following reasonable behavior to work once again:
>
>           from_raw(0x10de).as_raw() == 0x10de
>
>     * Added a new patch, to inline the remaining PCI operations. This
>       provides consistent inline choices throughout pci.rs.

I am far from a PCI expert, but regardless of bus considerations the
code appears to make sense to me (particularly since it removes some
uses of the `bindings` module!). Thus, and FWIW,

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>