linux-kernel - RE: [PATCH v2] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510DDAA3226A19CC52D4C88883BA@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Thu, 28 Aug 2025 01:37:36 +0000
From: Wei Fang <wei.fang@....com>
To: Inochi Amaoto <inochiama@...il.com>
CC: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Yixun Lan
	<dlan@...too.org>, Longbin Li <looong.bin@...il.com>, Linux Kernel Functional
 Testing <lkft@...aro.org>, Nathan Chancellor <nathan@...nel.org>, Jon Hunter
	<jonathanh@...dia.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Thomas Gleixner
	<tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>, Lorenzo Pieralisi
	<lpieralisi@...nel.org>, Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	Chen Wang <unicorn_wang@...look.com>
Subject: RE: [PATCH v2] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in
 cond_[startup|shutdown]_parent()

> For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT,
> the newly added callback irq_startup() and irq_shutdown() for
> pci_msi[x]_template will not unmask/mask the interrupt when startup/
> shutdown the interrupt. This will prevent the interrupt from being
> enabled/disabled normally.
> 
> Add the missing check for MSI_FLAG_PCI_MSI_MASK_PARENT in the
> cond_[startup|shutdown]_parent(). So the interrupt can be normally
> unmasked/masked if it does not support MSI_FLAG_PCI_MSI_MASK_PARENT.
> 
> Fixes: 54f45a30c0d0 ("PCI/MSI: Add startup/shutdown for per device
> domains")

Thanks for fixing this issue.

Tested-by: Wei Fang <wei.fang@....com>