linux-kernel - Re: [PATCH net-next v4 4/4] net: renesas: rswitch: add modifiable ageing time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <638d337a-6485-4eb3-a53c-c6fd7dadafbc@gmail.com>
Date: Thu, 28 Aug 2025 16:37:42 +0300
From: Sergey Shtylyov <sergei.shtylyov@...il.com>
To: Michael Dege <michael.dege@...esas.com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
 Niklas Söderlund <niklas.soderlund@...natech.se>,
 Paul Barker <paul@...rker.dev>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Nikita Yushchenko <nikita.yoush@...entembedded.com>
Subject: Re: [PATCH net-next v4 4/4] net: renesas: rswitch: add modifiable
 ageing time

On 8/28/25 1:23 PM, Michael Dege wrote:

> This commit allows the setting of the MAC table aging in the R-Car S4

    Please just use the imperative mood: Allow the setting...

> Rswitch using the SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute.
> 
> Signed-off-by: Michael Dege <michael.dege@...esas.com>
> ---
>  drivers/net/ethernet/renesas/rswitch_l2.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/drivers/net/ethernet/renesas/rswitch_l2.c b/drivers/net/ethernet/renesas/rswitch_l2.c
> index 49a24464dbb0cf3f3219a0699fc4671ddd71ef03..c57396af70a4b291746d6451eae7cf60b3f89721 100644
> --- a/drivers/net/ethernet/renesas/rswitch_l2.c
> +++ b/drivers/net/ethernet/renesas/rswitch_l2.c
> @@ -193,6 +193,25 @@ static int rswitch_netdevice_event(struct notifier_block *nb,
>  	return NOTIFY_OK;
>  }
>  
> +static int rswitch_update_ageing_time(struct net_device *ndev, clock_t time)
> +{
> +	struct rswitch_device *rdev = netdev_priv(ndev);
> +	u32 reg_val;
> +
> +	if (!is_rdev(ndev))
> +		return -ENODEV;
> +
> +	if (!FIELD_FIT(FWMACAGC_MACAGT, time))
> +		return -EINVAL;
> +
> +	rdev = netdev_priv(ndev);

   Haven't you already initialized rdev to the same value above?

[...]

MBR, Sergey