linux-kernel - Re: [PATCH 00/37] arm64: Add initial device trees for Apple M2 Pro/Max/Ultra devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250828165012.GC204299@robin.jannau.net>
Date: Thu, 28 Aug 2025 18:50:12 +0200
From: Janne Grunau <j@...nau.net>
To: Nick Chan <towinchenmi@...il.com>
Cc: Sven Peter <sven@...nel.org>, Alyssa Rosenzweig <alyssa@...enzweig.io>,
	Neal Gompa <neal@...pa.dev>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,	Hector Martin <marcan@...can.st>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,	Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>,	Robin Murphy <robin.murphy@....com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Mark Kettenis <kettenis@...nbsd.org>,	Andi Shyti <andi.shyti@...nel.org>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Sasha Finkelstein <fnkl.kernel@...il.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@...il.com>,
	Johannes Berg <johannes@...solutions.net>,
	van Spriel <arend@...adcom.com>, Lee Jones <lee@...nel.org>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Stephen Boyd <sboyd@...nel.org>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Michael Turquette <mturquette@...libre.com>,
	Martin Povišer <povik+lin@...ebit.org>,
	Vinod Koul <vkoul@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Marc Zyngier <maz@...nel.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,	Keith Busch <kbusch@...nel.org>,
 Jens Axboe <axboe@...nel.dk>,	Christoph Hellwig <hch@....de>,
 Sagi Grimberg <sagi@...mberg.me>,	Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>,	asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org,	devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org,	linux-pm@...r.kernel.org,
 iommu@...ts.linux.dev,	linux-gpio@...r.kernel.org,
 linux-i2c@...r.kernel.org,	dri-devel@...ts.freedesktop.org,
 linux-bluetooth@...r.kernel.org,	linux-wireless@...r.kernel.org,
 linux-pwm@...r.kernel.org,	linux-watchdog@...r.kernel.org,
 linux-clk@...r.kernel.org,	dmaengine@...r.kernel.org,
 linux-sound@...r.kernel.org,	linux-spi@...r.kernel.org,
 linux-nvme@...ts.infradead.org
Subject: Re: [PATCH 00/37] arm64: Add initial device trees for Apple M2
 Pro/Max/Ultra devices

On Fri, Aug 29, 2025 at 12:11:40AM +0800, Nick Chan wrote:
> 
> Janne Grunau 於 2025/8/28 晚上10:01 寫道:
> > This series adds device trees for Apple's M2 Pro, Max and Ultra based
> > devices. The M2 Pro (t6020), M2 Max (t6021) and M2 Ultra (t6022) SoCs
> > follow design of the t600x family so copy the structure of SoC *.dtsi
> > files.
> [...]
> > After discussion with the devicetree maintainers we agreed to not extend
> > lists with the generic compatibles anymore [1]. Instead either the first
> > compatible SoC or t8103 is used as fallback compatible supported by the
> > drivers. t8103 is used as default since most drivers and bindings were
> > initially written for M1 based devices.
> >
> > The series adds those fallback compatibles to drivers where necessary,
> > annotates the SoC lists for generic compatibles as "do not extend" and
> > adds t6020 per-SoC compatibles.
> 
> The series is inconsistent about the use of generic fallback compatibles.
> 
> "apple,aic2", "apple,s5l-fpwm", "apple,asc-mailbox-v4" is still used.

Those are less generic than say "apple,spi". For "apple,aic2" especially
it's clear which SoCs use it and the set is closed (ignoring iphone SoCs
which very likely will never run linux). For the interrupt controller
the fallout of not using the "apple,aic2" is larger since even m1n1
expect that. irq driver is special in so far as it requires more than
adding a compatible.
I think "apple,s5l-fpwm" and "apple,asc-mailbox-v4" are specific enough
and describe simple hardware so the will not cause issues unlike the
complex firmware based "apple,nvme-ans2".

Janne