linux-kernel - Re: [PATCH bpf-next v3 2/2] selftests/bpf: Add tests for bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4Bzb9WE27ngUVsYh0x0O85e891rbuX-YChDkCRm_U27_04Q@mail.gmail.com>
Date: Thu, 28 Aug 2025 10:02:28 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Rong Tao <rtoax@...mail.com>
Cc: ast@...nel.org, daniel@...earbox.net, vmalik@...hat.com, 
	Rong Tao <rongtao@...tc.cn>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>, 
	"open list:BPF [GENERAL] (Safe Dynamic Programs and Tools)" <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 2/2] selftests/bpf: Add tests for bpf_strnstr

On Thu, Aug 28, 2025 at 4:08 AM Rong Tao <rtoax@...mail.com> wrote:
>
> From: Rong Tao <rongtao@...tc.cn>
>
> Add two tests for bpf_strnstr():
>
>     bpf_strnstr("", "", 0) = 0
>     bpf_strnstr("hello world", "hello", 5) = 0
>
> Signed-off-by: Rong Tao <rongtao@...tc.cn>
> ---
>  tools/testing/selftests/bpf/progs/string_kfuncs_success.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/string_kfuncs_success.c b/tools/testing/selftests/bpf/progs/string_kfuncs_success.c
> index 46697f381878..1b56bd5860e9 100644
> --- a/tools/testing/selftests/bpf/progs/string_kfuncs_success.c
> +++ b/tools/testing/selftests/bpf/progs/string_kfuncs_success.c
> @@ -30,7 +30,9 @@ __test(2) int test_strcspn(void *ctx) { return bpf_strcspn(str, "lo"); }
>  __test(6) int test_strstr_found(void *ctx) { return bpf_strstr(str, "world"); }
>  __test(-ENOENT) int test_strstr_notfound(void *ctx) { return bpf_strstr(str, "hi"); }
>  __test(0) int test_strstr_empty(void *ctx) { return bpf_strstr(str, ""); }
> -__test(0) int test_strnstr_found(void *ctx) { return bpf_strnstr(str, "hello", 6); }
> +__test(0) int test_strnstr_found1(void *ctx) { return bpf_strnstr("", "", 0); }
> +__test(0) int test_strnstr_found2(void *ctx) { return bpf_strnstr(str, "hello", 5); }

add (str, "hello", 4) == -ENOENT case?

Also let's add negative ("", "a", 0) == -ENOENT case?

pw-bot: cr

> +__test(0) int test_strnstr_found3(void *ctx) { return bpf_strnstr(str, "hello", 6); }
>  __test(-ENOENT) int test_strnstr_notfound(void *ctx) { return bpf_strnstr(str, "hi", 10); }
>  __test(0) int test_strnstr_empty(void *ctx) { return bpf_strnstr(str, "", 1); }
>
> --
> 2.51.0
>