linux-kernel - Re: [PATCH net-next v14 4/5] net: ti: icssm-prueth: Adds link detection, RX and TX support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1892122434.246137.1756401137255.JavaMail.zimbra@couthit.local>
Date: Thu, 28 Aug 2025 22:42:17 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: kuba <kuba@...nel.org>
Cc: danishanwar <danishanwar@...com>, rogerq <rogerq@...nel.org>, 
	andrew+netdev <andrew+netdev@...n.ch>, davem <davem@...emloft.net>, 
	edumazet <edumazet@...gle.com>, pabeni <pabeni@...hat.com>, 
	robh <robh@...nel.org>, krzk+dt <krzk+dt@...nel.org>, 
	conor+dt <conor+dt@...nel.org>, ssantosh <ssantosh@...nel.org>, 
	richardcochran <richardcochran@...il.com>, 
	m-malladi <m-malladi@...com>, s hauer <s.hauer@...gutronix.de>, 
	afd <afd@...com>, jacob e keller <jacob.e.keller@...el.com>, 
	horms <horms@...nel.org>, johan <johan@...nel.org>, 
	m-karicheri2 <m-karicheri2@...com>, s-anna <s-anna@...com>, 
	glaroque <glaroque@...libre.com>, 
	saikrishnag <saikrishnag@...vell.com>, 
	kory maincent <kory.maincent@...tlin.com>, 
	diogo ivo <diogo.ivo@...mens.com>, 
	javier carrasco cruz <javier.carrasco.cruz@...il.com>, 
	basharath <basharath@...thit.com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	netdev <netdev@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	ALOK TIWARI <alok.a.tiwari@...cle.com>, 
	Bastien Curutchet <bastien.curutchet@...tlin.com>, 
	pratheesh <pratheesh@...com>, Prajith Jayarajan <prajith@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>, 
	mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v14 4/5] net: ti: icssm-prueth: Adds link
 detection, RX and TX support.

Hi,

> On Fri, 22 Aug 2025 20:09:16 +0530 Parvathi Pudi wrote:
>> +	struct net_device_stats *ndevstats;
> 
>> +	ndevstats = &emac->ndev->stats;
> 
> Please don't use netdev stats, quoting the header:
> 
>	struct net_device_stats	stats; /* not used by modern drivers */
> 
> Store the counters you need in driver's private struct and implement
> .ndo_get_stats64
> 

sure, we will verify and use the suggested approach.

>> +	if (!pkt_info->sv_frame) {
> 
> sv_frame seems to always be false at this stage?
> Maybe delete this diff if that's the case, otherwise it feels like
> the skb_free below should be accompanied by some stat increment.
> 

Yes, We will remove this for now.

>> +		skb_put(skb, actual_pkt_len);
>> +
>> +		/* send packet up the stack */
>> +		skb->protocol = eth_type_trans(skb, ndev);
>> +		netif_receive_skb(skb);
>> +	} else {
>> +		dev_kfree_skb_any(skb);
>> +	}
> 
> The rest LGTM.


Thanks and Regards
Parvathi.