linux-kernel - Re: [PATCH v10] rust: transmute: Add methods for FromBytes trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCDMNH6OY7NP.3UE5CGYETB8HI@nvidia.com>
Date: Thu, 28 Aug 2025 09:17:14 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Christian" <christiansantoslima21@...il.com>, "Miguel Ojeda"
 <miguel.ojeda.sandonis@...il.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <benno.lossin@...ton.me>,
 "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl"
 <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Danilo
 Krummrich" <dakr@...nel.org>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <~lkcamp/patches@...ts.sr.ht>,
 <richard120310@...il.com>
Subject: Re: [PATCH v10] rust: transmute: Add methods for FromBytes trait

On Tue Aug 26, 2025 at 4:51 AM JST, Christian wrote:
> Hi, Miguel.
>
>
>> > Link: https://github.com/Rust-for-Linux/linux/issues/1119
>> > Suggested-by: Alexandre Courbot <acourbot@...dia.com>
>>
>> Please add a link to the original suggestion if possible. If it is the
>> link above, then the tags should be in the opposite order.
>>
>> Did Benno and Alexandre both suggest it?
>
> Benno suggested the link to github in the issue there. Alexandre
> helped in most of the design. It was a mistake by my part not to
> specify that. Even if it's good, put you too as suggested-by, because
> the idea of using `is_aligned` was yours. Maybe Alexandre can put it
> there?
>
> If I understand correctly, should be:
>
> Suggested-by: Benno Lossin <benno.lossin@...ton.me>,
> Link: https://github.com/Rust-for-Linux/linux/issues/1119
>
> Suggested-by: Alexandre Courbot <acourbot@...dia.com>
> Link: https://lore.kernel.org/rust-for-linux/DC5INTQKY0EX.1T4HD6OU8C4PI@nvidia.com/
>
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72mnxRquFmjoJemb=3LSq+ZdUfs9J+HXTwM6AavprsVNUg@mail.gmail.com/

Unless Miguel disagrees, I'll just keep Benno's entry as what Miguel and
I did was more part of the regular review process IMHO.