linux-kernel - Re: [PATCH v2 3/4] media: uapi: v4l2-controls: Cleanup codec definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d4a5e5b61a5dad935d1d72f98641a6edf52c43a.camel@collabora.com>
Date: Thu, 28 Aug 2025 14:46:48 -0400
From: Nicolas Dufresne <nicolas.dufresne@...labora.com>
To: Paul Kocialkowski <paulk@...-base.io>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
	 <hverkuil@...all.nl>, Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v2 3/4] media: uapi: v4l2-controls: Cleanup codec
 definitions

Le dimanche 24 août 2025 à 20:07 +0200, Paul Kocialkowski a écrit :
> Move some fields closer to where they are used, add missing tabs
> and remove an extra newline.
> 
> Signed-off-by: Paul Kocialkowski <paulk@...-base.io>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
>  include/uapi/linux/v4l2-controls.h | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-
> controls.h
> index 7aef88465d04..2d30107e047e 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -1537,15 +1537,6 @@ struct v4l2_ctrl_h264_pred_weights {
>  	struct v4l2_h264_weight_factors weight_factors[2];
>  };
>  
> -#define V4L2_H264_SLICE_TYPE_P				0
> -#define V4L2_H264_SLICE_TYPE_B				1
> -#define V4L2_H264_SLICE_TYPE_I				2
> -#define V4L2_H264_SLICE_TYPE_SP				3
> -#define V4L2_H264_SLICE_TYPE_SI				4
> -
> -#define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED	0x01
> -#define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH		0x02
> -
>  #define V4L2_H264_TOP_FIELD_REF				0x1
>  #define V4L2_H264_BOTTOM_FIELD_REF			0x2
>  #define V4L2_H264_FRAME_REF				0x3
> @@ -1566,8 +1557,17 @@ struct v4l2_h264_reference {
>   * Maximum DPB size, as specified by section 'A.3.1 Level limits
>   * common to the Baseline, Main, and Extended profiles'.
>   */
> -#define V4L2_H264_NUM_DPB_ENTRIES 16
> -#define V4L2_H264_REF_LIST_LEN (2 * V4L2_H264_NUM_DPB_ENTRIES)
> +#define V4L2_H264_NUM_DPB_ENTRIES		16
> +#define V4L2_H264_REF_LIST_LEN			(2 *
> V4L2_H264_NUM_DPB_ENTRIES)
> +
> +#define V4L2_H264_SLICE_TYPE_P				0
> +#define V4L2_H264_SLICE_TYPE_B				1
> +#define V4L2_H264_SLICE_TYPE_I				2
> +#define V4L2_H264_SLICE_TYPE_SP				3
> +#define V4L2_H264_SLICE_TYPE_SI				4
> +
> +#define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED		0x01
> +#define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH			0x02
>  
>  #define
> V4L2_CID_STATELESS_H264_SLICE_PARAMS	(V4L2_CID_CODEC_STATELESS_BASE + 6)
>  /**
> @@ -1707,7 +1707,6 @@ struct v4l2_ctrl_h264_decode_params {
>  	__u32 flags;
>  };
>  
> -
>  /* Stateless FWHT control, used by the vicodec driver */
>  
>  /* Current FWHT version */

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)