lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d58425d4-8e4f-4b70-915f-322658e9878e@redhat.com>
Date: Thu, 28 Aug 2025 22:01:58 +0200
From: David Hildenbrand <david@...hat.com>
To: "Kalyazin, Nikita" <kalyazin@...zon.co.uk>,
 "pbonzini@...hat.com" <pbonzini@...hat.com>,
 "shuah@...nel.org" <shuah@...nel.org>
Cc: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "michael.day@....com" <michael.day@....com>,
 "jthoughton@...gle.com" <jthoughton@...gle.com>,
 "Roy, Patrick" <roypat@...zon.co.uk>, "Thomson, Jack"
 <jackabt@...zon.co.uk>, "Manwaring, Derek" <derekmn@...zon.com>,
 "Cali, Marco" <xmarcalx@...zon.co.uk>
Subject: Re: [PATCH v4 1/2] KVM: guest_memfd: add generic population via write

On 28.08.25 17:31, Kalyazin, Nikita wrote:
> write syscall populates guest_memfd with user-supplied data in a generic
> way, ie no vendor-specific preparation is performed.  This is supposed
> to be used in non-CoCo setups where guest memory is not
> hardware-encrypted.
> 
> The following behaviour is implemented:
>   - only page-aligned count and offset are allowed
>   - if the memory is already allocated, the call will successfully
>     populate it
>   - if the memory is not allocated, the call will both allocate and
>     populate
>   - if the memory is already populated, the call will not repopulate it
> 
> Signed-off-by: Nikita Kalyazin <kalyazin@...zon.com>
> ---

Just nothing that checkpatch complains about

a) Usage of "unsigned" instead of "unsigned int"

b) The From doesn't completely match the SOB: "Kalyazin, Nikita" vs 
"Nikita Kalyazin"

-- 
Cheers

David / dhildenb


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ