linux-kernel - Re: [PATCH v2 3/8] gpu: nova-core: firmware: process Booter and patch its signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d7377cdca7f9aa1574c924073a2fcbcf0544218.camel@nvidia.com>
Date: Thu, 28 Aug 2025 20:58:55 +0000
From: Timur Tabi <ttabi@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>, "lossin@...nel.org"
	<lossin@...nel.org>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "a.hindborg@...nel.org"
	<a.hindborg@...nel.org>, "simona@...ll.ch" <simona@...ll.ch>,
	"tmgross@...ch.edu" <tmgross@...ch.edu>, "alex.gaynor@...il.com"
	<alex.gaynor@...il.com>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>, "airlied@...il.com"
	<airlied@...il.com>, "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"gary@...yguo.net" <gary@...yguo.net>, "dakr@...nel.org" <dakr@...nel.org>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Alistair Popple <apopple@...dia.com>, Joel Fernandes <joelagnelf@...dia.com>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, John Hubbard
	<jhubbard@...dia.com>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v2 3/8] gpu: nova-core: firmware: process Booter and patch
 its signature

On Tue, 2025-08-26 at 13:07 +0900, Alexandre Courbot wrote:
> +struct HsHeaderV2 {
> +    /// Offset to the start of the signatures.
> +    sig_prod_offset: u32,
> +    /// Size in bytes of the signatures.
> +    sig_prod_size: u32,
> +    /// Offset to a `u32` containing the location at which to patch the signature in the
> microcode
> +    /// image.
> +    patch_loc: u32,
> +    /// Offset to a `u32` containing the index of the signature to patch.
> +    patch_sig: u32,
> +    /// Start offset to the signature metadata.
> +    meta_data_offset: u32,
> +    /// Size in bytes of the signature metadata.
> +    meta_data_size: u32,
> +    /// Offset to a `u32` containing the number of signatures in the signatures section.
> +    num_sig: u32,
> +    /// Offset of the application-specific header.
> +    header_offset: u32,
> +    /// Size in bytes of the application-specific header.
> +    header_size: u32,
> +}

You are inconsistent with the names of offset fields in this struct.

patch_loc should be patch_loc_offset
patch_sig should be patch_sig_offset
num_sig should be num_sig_offset