linux-kernel - Re: [PATCH v3] hwmon: (coretemp) Replace x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f1fbf32-fd37-420c-82bc-a43e6d5ef57a@roeck-us.net>
Date: Thu, 28 Aug 2025 14:42:36 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Sohil Mehta <sohil.mehta@...el.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>, linux-hwmon@...r.kernel.org,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
	Zhang Rui <rui.zhang@...el.com>,
	Dave Hansen <dave.hansen@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] hwmon: (coretemp) Replace x86_model checks with VFM
 ones

On Thu, Aug 28, 2025 at 01:17:29PM -0700, Sohil Mehta wrote:
> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> Intel CPUs have been using Family 6 for a while. The Family-model checks
> in the coretemp driver implicitly assume Family 6. With the upcoming
> Family 18 and 19 models, some of these checks fall apart.
> 
> While reading the temperature target MSR, cpu_has_tjmax() performs model
> checks only to determine if a device warning should be printed. Instead
> of expanding the checks, get rid of the function and print the warning
> once unconditionally if the MSR read fails. The checks aren't worth
> preventing a single line warning to dmesg.
> 
> Update the rest of the x86_model checks with VFM ones to make them more
> robust. This automatically covers the upcoming Family 18 and 19 as well
> as any future extended families.
> 
> Add a code comment to reflect that none of the CPUs in Family 5 or
> Family 15 set X86_FEATURE_DTHERM. The VFM checks do not impact these
> CPUs since the driver does not load on them.
> 
> Missing-signoff: Dave Hansen <dave.hansen@...ux.intel.com>
> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>

Checkpatch really doesn't like that:

ERROR: Missing Signed-off-by: line by nominal patch author 'Dave Hansen <dave.hansen@...ux.intel.com>'

Never mind, applied anyway.

Guenter