linux-kernel - Re: [PATCH v3] hwmon: (coretemp) Replace x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c68f0cc1-f84b-4458-bdb4-e017443c2125@roeck-us.net>
Date: Thu, 28 Aug 2025 14:47:36 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Dave Hansen <dave.hansen@...el.com>, Sohil Mehta <sohil.mehta@...el.com>,
 Jean Delvare <jdelvare@...e.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 linux-hwmon@...r.kernel.org
Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
 Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
 Zhang Rui <rui.zhang@...el.com>, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] hwmon: (coretemp) Replace x86_model checks with VFM
 ones

On 8/28/25 14:18, Dave Hansen wrote:
> On 8/28/25 13:17, Sohil Mehta wrote:
>>
>> Add a code comment to reflect that none of the CPUs in Family 5 or
>> Family 15 set X86_FEATURE_DTHERM. The VFM checks do not impact these
>> CPUs since the driver does not load on them.
>>
>> Missing-signoff: Dave Hansen <dave.hansen@...ux.intel.com>
>> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
> 
> Thanks for picking this back up from whatever dark hole I left it in! ;)
> 
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> I assume the hwmon folks will pick this up. If not, it's certainly
> x86-ish enough for it to go through tip.
> 
Already done, but if you want to take it through some other branch
let me know and I'll drop it.

> Oh, and do we want to cc:stable@ on this? Could this end up biting
> anybody running an old kernel on the model 18/19 hardware?

It doesn't really bite, it will just not instantiate the driver.
I have no idea if those old kernels would run with the new hardware
in the first place. You tell me...

Personally I'd rather wait until someone complains.

Guenter