linux-kernel - Re: [PATCH v3] hwmon: (coretemp) Replace x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51537b9e-46a8-4dd1-93fb-bb14ea15e6a2@intel.com>
Date: Thu, 28 Aug 2025 15:33:10 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Dave Hansen <dave.hansen@...el.com>, Guenter Roeck <linux@...ck-us.net>
CC: Dave Hansen <dave.hansen@...ux.intel.com>, <linux-hwmon@...r.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, Ricardo Neri
	<ricardo.neri-calderon@...ux.intel.com>, Zhang Rui <rui.zhang@...el.com>,
	<x86@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] hwmon: (coretemp) Replace x86_model checks with VFM
 ones

On 8/28/2025 2:51 PM, Dave Hansen wrote:
> Let's just wait until Guenter sends it upstream. Once it hits Linus's
> tree, you can ask for it to be in stable if we decide it's a good idea.
> 

Sure, sounds good.

> I asked if it was necessary because I'm not positive it's a good idea.
> 

The model numbers in play are around 14, 15, 23. In some cases, the
model number is used to determine if a sysfs attribute should be
created. So, for lower model numbers, the TTARGET attr probably won't be
created.

	if (c->x86_model > 0xe && c->x86_model != 0x1c)
		if (get_ttarget(tdata, &pdev->dev) >= 0)
			tdata->attr_size++;

	/* Create sysfs interfaces */
	err = create_core_attrs(tdata, pdata->hwmon_dev);

In some other cases, the temperature adjustment would vary slightly.
But, nothing scary for now.

> So, let's actually look at what it would mean in practice to have it hit
> stable@ or not. Just spent 10 minutes looking at it.

Yeah, I am fine with deciding based on the severity of the practical impact.