linux-kernel - Re: [PATCH RFC 07/22] usb: dwc3: apple: Adjust vendor-specific registers during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250828225145.lma4lp2afvmuop2l@synopsys.com>
Date: Thu, 28 Aug 2025 22:51:46 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Sven Peter <sven@...nel.org>
CC: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Felipe Balbi <balbi@...nel.org>,
        Janne Grunau <j@...nau.net>, Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Neal Gompa <neal@...pa.dev>, Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "asahi@...ts.linux.dev" <asahi@...ts.linux.dev>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        Hector Martin <marcan@...can.st>
Subject: Re: [PATCH RFC 07/22] usb: dwc3: apple: Adjust vendor-specific
 registers during init

On Sat, Aug 23, 2025, Sven Peter wrote:
> Hi Thinh,
> 
> On 22.08.25 00:18, Thinh Nguyen wrote:
> > For this patch, however, I'd prefer these vendor-specific settings to be
> > in their own glue driver. I can only imagine more changes will be
> > introduced in the future with this vendor. See if we can use the new
> > glue interface in glue.h (some call this the new "flatten" model) when
> > creating a glue driver.
> 
> Nice, thanks! Hints like that are exactly what I was hoping for when
> I sent this RFC.
> 
> When I originally started working on this I tried to use the parent/child
> model but didn't really get anywhere. This flattened model looks very useful
> though.
> 
> I think I can even move some of logic from the previous commits to
> dwc3-apple.c if I extend the glue a little bit. I'll see how that works out
> and maybe do that for the next version then.
> 

That's great! I'll look forward to your updates.

Check this change for inspirations for extending the glue interface:
https://lore.kernel.org/linux-usb/20250815004207.xwv4n6xsat44bydi@synopsys.com/T/#u

Thanks,
Thinh